Skip to content

B004 OMCSession / OMSessionABC#429

Open
syntron wants to merge 10 commits intoOpenModelica:masterfrom
syntron:B004-OMCSession_OMSessionABC
Open

B004 OMCSession / OMSessionABC#429
syntron wants to merge 10 commits intoOpenModelica:masterfrom
syntron:B004-OMCSession_OMSessionABC

Conversation

@syntron
Copy link
Contributor

@syntron syntron commented Feb 27, 2026

(B004) define OMCSession:OMSessionABC

[OMCSession] update OMCSession* to use OMSessionABC as baseline and further cleanup

[ModelicaSystem] shortcut to use OMCSession = OMSessionABC for now

[ModelicaSystem] fix usage of OMCSession; replace by OMSessionABC

fix usage of OMCSession

[OMSessionABC] fix OMCPath; rename to OMPathABC

[ModelicaSystemDoE] simplify definition; use a Modelicasystem instance as argument

[ModelicaSystemDoE] update docstring

[ModelicaSystemDoE] fix for relative paths

[ModelicaSystemDoE] fix unittest

* test_ModelicaSystemDoE_local is tested
* test_ModelicaSystemDoE_docker should work
* test_ModelicaSystemDoE_WSL is untested
[ModelExecution*] create classes to handle model execution

* rename ModelicaSystemCmd => ModelExecutionCmd
* rename OMCSessionRunData => ModelExecutionData
* create class ModelExecutionException
* move some code:
  * OMCSession.omc_run_data_update() => merge into ModelExecutionCmd.define()
  * OMCSession.run_model_executable() => ModelExecutionData.run()

[test_ModelicaSystemCmd] update unittest

[ModelExecutionData] include the original exception if reraised as ModelExecutionException

[ModelicaSystem] fix usage of ModelicaSystemCmd
[ModelicaSystem] split ModelicaSystem into ModelicaSystemABC and ModelicaSystem

[ModelicaSystem] rename ModelicaSystem => ModelicaSystemOMC

* add compatibility variable for ModelicaSystem

[test_ModelicaSystemOMC] rename from ModelicaSystem and update

[test_*] use ModelicaSystemOMC

[ModelicaSystem*] fix last usages of ModelicaSystem() in comments & docstrings
[ModelicaSystem] split ModelicaSystemDoE into ModelicaDoEABC and ModelicaDoE

[ModelicaSystem] rename ModelicaSystemDoE => ModelicaDoEOMC

* add compatibility variable for ModelicaSystemDoE

[test_ModelicaDoEOMC] rename from ModelicaSystemDoE and update

[ModelicaSystem] update ModelicaDoEABC to use ModelicaSystemABC

[ModelicaSystem] define doe_get_solutions() as separate method
[OMCSession] update OMCPath to use OMPathABC as baseline and further cleanup

[ModelicaSystem] shortcut to use OMCPath = OMPathABC for now

[ModelicaSystem] fix usage of OMCPath; replace by OMPathABC

[OMCSession] move OM(C)Path classes into the if cause

[OMCSession] define and use OMPathBase

[OMCSession] align on OMPathABC; replace usage of OMPathBase
[OMCSession] update OMCSession* to use OMSessionABC as baseline and further cleanup

[ModelicaSystem] shortcut to use OMCSession = OMSessionABC for now

[ModelicaSystem] fix usage of OMCSession; replace by OMSessionABC

fix usage of OMCSession

[OMSessionABC] fix OMCPath; rename to OMPathABC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant